Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment context chips in list and view comp feature added #1445

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Segment context chips in list and view comp feature added #1445

merged 5 commits into from
Apr 29, 2024

Conversation

Yagnik56
Copy link
Collaborator

This PR add feature of chips on segment context functional by clicking on them search filter is set on that context.

@Yagnik56 Yagnik56 self-assigned this Apr 12, 2024
@bcb37 bcb37 self-requested a review April 15, 2024 19:54
bcb37
bcb37 requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@bcb37 bcb37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the segment constants consistent with the experiment ones, we should import them from 'upgrade_types'. We'll also need to add them to types/src/index.ts.

frontend/projects/upgrade/src/app/core/segments/store/segments.model.ts Outdated Show resolved Hide resolved
bcb37
bcb37 previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@bcb37 bcb37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not quite the same as the way it's done with experiments, where the constants are re-exported from the model and imported from the model in the services. But it's not clear to me why that was done, so this is probably fine.

@Yagnik56
Copy link
Collaborator Author

This is still not quite the same as the way it's done with experiments, where the constants are re-exported from the model and imported from the model in the services. But it's not clear to me why that was done, so this is probably fine.

@bcb37 can you approve PR again as there was merge conflict I had to resolve so your approval dismissed

@Yagnik56 Yagnik56 requested a review from bcb37 April 19, 2024 09:20
VivekFitkariwala
VivekFitkariwala requested changes Apr 22, 2024
View reviewed changes
types/src/Experiment/enums.ts Outdated Show resolved Hide resolved
frontend/projects/upgrade/src/app/core/segments/store/segments.effects.ts Outdated Show resolved Hide resolved
frontend/projects/upgrade/src/app/core/segments/store/segments.effects.ts Outdated Show resolved Hide resolved
frontend/projects/upgrade/src/app/core/segments/segments.service.spec.ts Show resolved Hide resolved
...rade/src/app/features/dashboard/home/components/experiment-list/experiment-list.component.ts Outdated Show resolved Hide resolved
...rade/src/app/features/dashboard/segments/components/segments-list/segments-list.component.ts Outdated Show resolved Hide resolved
...rade/src/app/features/dashboard/segments/components/segments-list/segments-list.component.ts Show resolved Hide resolved
@Yagnik56 Yagnik56 merged commit f398e84 into dev Apr 29, 2024
8 checks passed
@Yagnik56 Yagnik56 deleted the enhancement/make-segment-context-chips-for-search-functional branch April 29, 2024 07:22
@Yagnik56 Yagnik56 linked an issue May 23, 2024 that may be closed by this pull request
Segment List Page chips and autocomplete functionality for search bar #1415
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VivekFitkariwala VivekFitkariwala VivekFitkariwala approved these changes

@ppratikcr7 ppratikcr7 Awaiting requested review from ppratikcr7

@bcb37 bcb37 Awaiting requested review from bcb37

Assignees

@Yagnik56 Yagnik56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segment List Page chips and autocomplete functionality for search bar
3 participants
@Yagnik56 @VivekFitkariwala @bcb37